Skip to content

fix(localizations): add placeholder text for username field in en-GB#8029

Closed
petiteoh wants to merge 5 commits intomainfrom
fix/username-placeholder-en-gb
Closed

fix(localizations): add placeholder text for username field in en-GB#8029
petiteoh wants to merge 5 commits intomainfrom
fix/username-placeholder-en-gb

Conversation

@petiteoh
Copy link
Contributor

@petiteoh petiteoh commented Mar 10, 2026

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Bug Fixes
    • Restored placeholder text for the username input in English (GB): "Enter your username".
  • Chores
    • Added a changeset entry to record the localization update.
    • Added a helper script to automate creating the changeset.

@vercel
Copy link

vercel bot commented Mar 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Mar 11, 2026 1:46pm

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2026

🦋 Changeset detected

Latest commit: 7f88ecd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/localizations Patch
@clerk/ui Patch
@clerk/chrome-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@petiteoh petiteoh changed the title add placeholder text for username field in en-GB fix(localizations): add placeholder text for username field in en-GB Mar 10, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 10, 2026

📝 Walkthrough

Walkthrough

This PR sets the en-GB localization value formFieldInputPlaceholder__username to "Enter your username" in the exported enGB LocalizationResource, adds a changeset file for the package, and adds a helper script plus a package.json script to create that changeset. No exported API signatures or structural logic were changed.

Possibly related PRs

  • clerk/javascript PR 8002: Adds the same formFieldInputPlaceholder__username value ("Enter your username") in the en-US locale file.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title clearly and specifically describes the main change: adding placeholder text for the username field in the en-GB locale, which is the core objective of the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 10, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8029

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8029

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8029

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8029

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8029

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8029

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8029

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8029

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8029

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8029

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8029

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8029

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8029

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8029

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8029

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8029

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8029

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8029

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8029

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8029

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8029

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8029

commit: 7f88ecd

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.changeset/sharp-dancers-hear.md:
- Around line 1-5: The changeset incorrectly marks '@clerk/localizations' as
"major" even though the change is a backward-compatible locale addition; update
the changeset entry to "patch" (replace the "major" tag for
'@clerk/localizations' with "patch") so it matches the intended non-breaking
locale copy and aligns with scripts/add-en-gb-changeset.mjs, and verify the body
still describes the en-GB username placeholder addition.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 3f19911e-eb78-47c5-abad-1549cf676e7c

📥 Commits

Reviewing files that changed from the base of the PR and between 224903c and e7b2a8d.

📒 Files selected for processing (3)
  • .changeset/sharp-dancers-hear.md
  • package.json
  • scripts/add-en-gb-changeset.mjs

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.changeset/sharp-dancers-hear.md (1)

5-5: Consider improving the description for clarity and consistency.

The description could be more informative and consistent with the script's output. Consider capitalizing the first letter and adding the specific placeholder text value for better documentation.

📝 Suggested improvement for description
-add placeholder text for username field in en-GB
+Add placeholder text "Enter your username" for username field in en-GB locale
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.changeset/sharp-dancers-hear.md at line 5, Summary: The changeset
description is vague and inconsistent in casing; update it to be clearer and
include the actual placeholder value. Edit the changeset description in
.changeset/sharp-dancers-hear.md (the changeset description block) to start with
a capital letter and explicitly state the placeholder text being added for the
username field in en-GB (for example: "Add placeholder text 'username' for the
username field in en-GB" or similar), ensuring consistency with the script
output.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.changeset/sharp-dancers-hear.md:
- Line 5: Summary: The changeset description is vague and inconsistent in
casing; update it to be clearer and include the actual placeholder value. Edit
the changeset description in .changeset/sharp-dancers-hear.md (the changeset
description block) to start with a capital letter and explicitly state the
placeholder text being added for the username field in en-GB (for example: "Add
placeholder text 'username' for the username field in en-GB" or similar),
ensuring consistency with the script output.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 611580fe-3c33-48e8-8548-2c95b4df81b9

📥 Commits

Reviewing files that changed from the base of the PR and between e7b2a8d and 7f88ecd.

📒 Files selected for processing (1)
  • .changeset/sharp-dancers-hear.md

@petiteoh petiteoh closed this Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant